cdransf/coryd.dev
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(dialogs): remove excessive duplicate markup for fallback modal hack

Browse source
This commit is contained in:
Cory Dransfeldt 2025-04-15 08:48:36 -07:00
parent 33c00fa74b
commit 3d866262ca
No known key found for this signature in database
12 changed files with 58 additions and 106 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/pages/dynamic/artist.php.liquid
View file

@ -81,7 +81,7 @@ schema: artist
$venue = htmlspecialchars($concert["venue_name_short"]);
}
}
$modalId = "modal-" . htmlspecialchars($concert["id"]);
$dialogId = "dialog-" . htmlspecialchars($concert["id"]);
?>
<li class="concerts">
On <mark><?php echo date("F j, Y", strtotime($concert["date"])); ?></mark>
@ -90,25 +90,11 @@ schema: artist
<?php endif; ?>
<?php if (!empty($concert["notes"])): ?>
<?php $notes = "### Notes\n" . htmlspecialchars($concert["notes"]); ?>
<noscript>
<input class="modal-input" id="<?php echo $modalId; ?>" type="checkbox" tabindex="0" />
<label class="modal-open" for="<?php echo $modalId; ?>">
{% tablericon "info-circle" %}
</label>
<div class="modal-wrapper">
<div class="modal-body">
<label class="modal-close" for="<?php echo $modalId; ?>">
{% tablericon "circle-x" %}
</label>
<?php echo parseMarkdown($notes); ?>
</div>
</div>
</noscript>
<button class="modal-open client-side" data-modal-trigger="<?php echo $modalId; ?>" data-modal-button>
<button class="dialog-open client-side" data-dialog-trigger="<?php echo $dialogId; ?>" data-dialog-button>
{% tablericon "info-circle" %}
</button>
<dialog id="dialog-<?php echo $modalId; ?>" class="client-side">
<button class="modal-close" data-modal-button>
<dialog id="dialog-<?php echo $dialogId; ?>" class="client-side">
<button class="dialog-close" data-dialog-button>
{% tablericon "circle-x" %}
</button>
<?php echo parseMarkdown($notes); ?>

18
src/pages/media/music/concerts.html
View file

@ -32,14 +32,16 @@ permalink: "/music/concerts/{% if pagination.pageNumber > 0 %}{{ pagination.page
<li>
<strong>{{ artistName }}</strong> on {{ concert.date | date: "%B %e, %Y" }}
{% if venue %} at {{ venue }}{% endif %}
{%- if concert.notes -%}
{% assign notes = concert.notes | prepend: "### Notes\n" | markdown %}
{% render "blocks/modal.liquid",
icon:"info-circle",
content:notes,
id:concert.id
%}
{%- endif -%}
<span class="client-side" style="display:inline">
{%- if concert.notes -%}
{% assign notes = concert.notes | prepend: "### Notes\n" | markdown %}
{% render "blocks/dialog.liquid",
icon:"info-circle",
content:notes,
id:concert.id
%}
{%- endif -%}
<span class="client-side">
</li>
{%- endfor -%}
</ul>